Is there something wrong with this?

[Adrian]

When I try this on MS C++2005 it takes the bad stream branch, and I
have no idea why. Borland and Gcc both do what I would expect.

Have I done something stupid?

#include <iostream>
#include <string>
#include <sstream>

int main()
{
int x=0;
std::string s("17,17,0,C,TOR,129/143");

std::istringstream strm(s);

strm >> x;

if(strm.good())
{
std::cout << x;
}
else
{
std::cout << "bad stream";
}

return 0;
}

 

[Alf P. Steinbach]

* Adrian:

When I try this on MS C++2005 it takes the bad stream branch, and I have
no idea why. Borland and Gcc both do what I would expect.

Have I done something stupid?

#include <iostream>
#include <string>
#include <sstream>

int main()
{
int x=0;
std::string s("17,17,0,C,TOR,129/143");

std::istringstream strm(s);

strm >> x;

if(strm.good())
{
std::cout << x;
}
else
{
std::cout << "bad stream";
}

return 0;
}

good() is not the opposite of fail().

Yeah, it's stupid.

But that's the way it is.

 

[Noah Roberts]

* Adrian:

good() is not the opposite of fail().

Yeah, it's stupid.

But that's the way it is

According to Josutis goodbit means that all the rest are off. That
means one of eofbit, failbit, or badbit must be set. It seems to me
that none of those apply; the value of x should be 17 and the next
character in the stream should be ',' no?

 

[Nate Silva]

int x=0;
std::string s("17,17,0,C,TOR,129/143");

std::istringstream strm(s);

strm >> x;

Microsoft C++ thinks the comma is a thousands separator.

 

[Nate Silva]

Microsoft C++ thinks the comma is a thousands separator.

Followup: it is a known bug in Visual C++.

http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=98836

Nate

 

[Adrian]

Microsoft C++ thinks the comma is a thousands separator.

Thanks for that Nate.