minitest/spec pull request

[Brian Takita]

Hello, I submitted a change request that makes the failure output in
mini spec show the exact string of the describe block, rather than the
camel-cased version of the string.
http://github.com/seattlerb/minitest/pull/4

I was wondering what people thought.

e.g.

describe "A fool" do
describe "Running a fools errand" do
it "is impotent" do
true.must_eql false
end
end
end

1) Failure:
test_0001_is_impotent(AFoolSpec::RunningAFoolsErrandSpec)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

This patch creates the following output:

1) Failure:
test_0001_is_impotent(A fool::Running a fools errand)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

Converting the it block to test_0001_is_impotent is a bit weird too.
Maybe the method could just have 'test' prepended to the exact string?

1) Failure:
test_0001 - is impotent (A fool::Running a fools errand)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

Thank you,
Brian

 

[Brian Takita]

Hello, I submitted a change request that makes the failure output in
mini spec show the exact string of the describe block, rather than the
camel-cased version of the string.
http://github.com/seattlerb/minitest/pull/4

Oops, I messed up the pull request. Here is the correct one.
http://github.com/seattlerb/minitest/pull/5

I was wondering what people thought.

e.g.

describe "A fool" do
=A0describe "Running a fools errand" do
=A0 =A0it "is impotent" do
=A0 =A0 =A0true.must_eql false
=A0 =A0end
=A0end
end

=A01) Failure:
test_0001_is_impotent(AFoolSpec::RunningAFoolsErrandSpec)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

This patch creates the following output:

=A01) Failure:
test_0001_is_impotent(A fool::Running a fools errand)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

Converting the it block to test_0001_is_impotent is a bit weird too.
Maybe the method could just have 'test' prepended to the exact string?

=A01) Failure:
test_0001 - is impotent (A fool::Running a fools errand)
[/home/honk/workspace/honk/junk.rb:9]:
Expected false, not true.

Thank you,
Brian