New to python looking for help

[J 7H0NG]

Hi I have been studying python for a few weeks and have made a few small projects, one of them being a lottery number generator. I was wondering what typical nooby mistakes I have made, also what I could do to clean up my code to make it look nicer. Would also help if someone would give me a suggestion on what else I could add onto it (don't tell me how to do it just give me suggestion please)

import random
nums = list(range(1,51))
nums2 = list(range(1,12))
random.shuffle(nums)
random.shuffle(nums2)
range_of_numbers = nums[:5]
range_of_numbers2 = nums2[:2]
range_of_numbers2.sort()
range_of_numbers.sort()

print("Your Lottery Numbers Are: " + str(range_of_numbers) + ("\nYour Jackpot Numbers Are: ") + str(range_of_numbers2))
question1 = input("Are you happy with your Numbers?")
print("Good Luck! ") if question1 == ("Yes") or ("yes") else print ("Sorry try again")

while question1 == ("No"):
print("Your Lottery Numbers Are: " + str(range_of_numbers) + ("\nYour Jackpot Numbers Are: ") + str(range_of_numbers2))
question1 = input("Are you happy with your Numbers?: ")

Also if anyone has any courses i can take to better my skills id be more than happy to hear it , im currently doing the cs50p course.
Thanks.

 

[menator01]

I would probably take this approach. Note: There is not any error checking in this example.

from random import choices

# Create a list of numbers
numbers = list(range(1, 101))

# Start the while loop
while True:

    # Create a lottery number of 7 numbers
    random_numbers = choices(numbers, k=7)

    # Print instructions
    print('Enter 7 numbers between 1 and 100 seperated by a space')

    # Get user input and put in a list
    guess = input('>> ').split()

    # Sort the numbers
    numbers.sort()
    guess.sort()
    
    # Compare the list
    if guess == random_numbers:
        print('You win the lottery')
    else:
        print('Sorry, You didn\'t win.')
    
    # Ask if user wants to play again
    ask = input('Play Again? (y/n)\>> ')
    if ask.lower() == 'n':
        print('Goodbye!')
        break

 

[VBService]

# Sort the numbers
numbers.sort()

IMHO random_numbers.sort()

 

[J 7H0NG]

I would probably take this approach. Note: There is not any error checking in this example.

from random import choices

# Create a list of numbers
numbers = list(range(1, 101))

# Start the while loop
while True:

    # Create a lottery number of 7 numbers
    random_numbers = choices(numbers, k=7)

    # Print instructions
    print('Enter 7 numbers between 1 and 100 seperated by a space')

    # Get user input and put in a list
    guess = input('>> ').split()

    # Sort the numbers
    numbers.sort()
    guess.sort()
   
    # Compare the list
    if guess == random_numbers:
        print('You win the lottery')
    else:
        print('Sorry, You didn\'t win.')
   
    # Ask if user wants to play again
    ask = input('Play Again? (y/n)\>> ')
    if ask.lower() == 'n':
        print('Goodbye!')
        break

Thanks for this, its really helpful to look at code created by someone more experienced to understand the structure of how code should look. Do you know any courses I could take that you could recommend that would help me with my journey to learning python? I'm looking for something with a lot of practical work (building projects ect) as appose to just theory work and watching videos. Thanks again!!

 

[VBService]

...

    random_numbers = choices(numbers, k=7)
    guess = input('>> ').split()
    ...
 
    # Compare the list
    if guess == random_numbers:
        print('You win the lottery')
    else:
        print('Sorry, You didn\'t win.')

Seriously?

The probability of hitting a win is approximately 7! * 100!
Good luck with this game
[ on-line ]

from random import choices
from time import sleep

# Create a list of numbers
numbers = list(range(1, 101))

# Create a lottery number of 7 numbers
random_numbers = choices(numbers, k=7)

# Sort the numbers
random_numbers.sort()

guess_counter = 0

# Start the while loop
while True:
    guess = choices(numbers, k=7)  # Simulation of user input seven numbers
    guess.sort()
   
    guess_counter = guess_counter + 1
    print(f'-{guess_counter:-<28}')
    print(f'{random_numbers}\n{guess}\n', sep='')
   
    sleep(.5)
   
    if guess == random_numbers:
        break

print(f'You won after {guess_counter} draws')