M
Morris Dovey
broli said:
Vatiable c must be an int.
Vatiable c must be an int.
M
Morris Dovey
broli said:
Hmm - did you re-compile and re-link after making the changes?
B
broli
I cannot understand why the program goes into infinite loop after the
file is printed on the screen.
#include<stdio.h>
int main(void)
{
FILE *fp;
char c;
fp = fopen("sample.dat", "r");
if(fp == NULL)
{
printf("Cannot open the file\n");
return 0;
}
while(1)
{
c = fgetc(fp);
if(c == EOF)
break;
else
printf("%c",c);
}
fclose(fp);
return 0;
}
sample.dat
as;djasjd;asjd
asdsaddskaslkldsklasdklsdklaklasdklaskldaskl
;lkasdasdkksdlaklasdklsad;klasd;klaskdl;
file is printed on the screen.
#include<stdio.h>
int main(void)
{
FILE *fp;
char c;
fp = fopen("sample.dat", "r");
if(fp == NULL)
{
printf("Cannot open the file\n");
return 0;
}
while(1)
{
c = fgetc(fp);
if(c == EOF)
break;
else
printf("%c",c);
}
fclose(fp);
return 0;
}
sample.dat
as;djasjd;asjd
asdsaddskaslkldsklasdklsdklaklasdklaskldaskl
;lkasdasdkksdlaklasdklsad;klasd;klaskdl;
W
Willem
broli wrote:
) I cannot understand why the program goes into infinite loop after the
) file is printed on the screen.
<snip>
) FILE *fp;
) char c;
Here's the error.
<snip>
) c = fgetc(fp);
) if(c == EOF)
EOF is not a value that fits in a char.
c should be an int, not a char.
SaSW, Willem
--
Disclaimer: I am in no way responsible for any of the statements
made in the above text. For all I know I might be
drugged or something..
No I'm not paranoid. You all think I'm paranoid, don't you !
#EOT
) I cannot understand why the program goes into infinite loop after the
) file is printed on the screen.
<snip>
) FILE *fp;
) char c;
Here's the error.
<snip>
) c = fgetc(fp);
) if(c == EOF)
EOF is not a value that fits in a char.
c should be an int, not a char.
SaSW, Willem
--
Disclaimer: I am in no way responsible for any of the statements
made in the above text. For all I know I might be
drugged or something..
No I'm not paranoid. You all think I'm paranoid, don't you !
#EOT
S
santosh
broli said:
Here is your first mistake. Fgetc returns an int value, not a char. This
is because the out-of-band value EOF is an int. You need to store
fgetc's return value in an int, test it if it is EOF and assign to a
char only if it is an ordianary character.
This check will fail because of what I said above.
B
broli
Yes now I recall reading this in K & R 2. Strangely I found this wrong
approach( char c = EOF) being used in many online tutorials.
B
broli
After changing to int, Im still getting an infinite loop -
#include<stdio.h>
int main(void)
{
FILE *fp;
int c;
fp = fopen("sample.dat", "r");
if(fp == NULL)
{
printf("Cannot open the file\n");
return 0;
}
while(1)
{
c = fgetc(fp);
if(c == EOF)
{
break;
}
else
printf("%c",c);
}
return 0;
}
#include<stdio.h>
int main(void)
{
FILE *fp;
int c;
fp = fopen("sample.dat", "r");
if(fp == NULL)
{
printf("Cannot open the file\n");
return 0;
}
while(1)
{
c = fgetc(fp);
if(c == EOF)
{
break;
}
else
printf("%c",c);
}
return 0;
}
M
Morris Dovey
broli said:
I don't have XP, but use TC3 under 95, 98, and ME without problem
- but much prefer to boot up Linux and use gcc.
Actually, I don't think you'll find anything very much easier to
use than your Turbo C package. I think version 3 is available for
free download if you think it might solve any of your problems.
My favorite trick is making changes in an edit window, then
compiling, linking, and running the program without having saved
my changed source file.
F
Flash Gordon
broli wrote, On 15/03/08 09:51:
That just shows you why you should not rely on random online tutorials.
Within the past week or so there was a question about tutorials and
links to the few known good ones were posted.
That just shows you why you should not rely on random online tutorials.
Within the past week or so there was a question about tutorials and
links to the few known good ones were posted.
R
Richard Heathfield
broli said:
Most online tutorials are either platform-specific, deeply flawed (in ways
such as the one you've seen, and much worse besides), or both.
http://www.eskimo.com/~scs/cclass/ and http://cprog.tomsweb.net/cintro.html
are both excellent.
Most online tutorials are either platform-specific, deeply flawed (in ways
such as the one you've seen, and much worse besides), or both.
http://www.eskimo.com/~scs/cclass/ and http://cprog.tomsweb.net/cintro.html
are both excellent.
R
Richard Heathfield
broli said:
If you don't *want* an infinite loop, why use while(1)?
while((c = getc(fp)) != EOF)
{
putchar(c);
}
Having said that, the code you posted looks like it should work just fine.
I suspect that it is somewhat different from the code you executed.
If you don't *want* an infinite loop, why use while(1)?
while((c = getc(fp)) != EOF)
{
putchar(c);
}
Having said that, the code you posted looks like it should work just fine.
I suspect that it is somewhat different from the code you executed.
S
santosh
Morris said:Hmm - did you re-compile and re-link after making the changes?
Perhaps he is piping 'yes' into his program?
B
broli
I use TC 2.01 on win xp and to be honest it has given me many
problems. I want to use a different and easier complier, I have looked
around but cannot find one.
problems. I want to use a different and easier complier, I have looked
around but cannot find one.
S
santosh
broli said:
Try MinGW, Cygwin, Borland's free command line compiler or Microsoft's
Express 2008, or lcc-win32 or PellesC etc.
You are spoiled for choice!
B
broli
lcc-win32.. is it freely available on jacob navias website ?
R
Richard Heathfield
broli said:
I think it's probably the other way around. I've just tested the
program you posted, the one with:
int c;
and
while(1)
{
c = fgetc(fp);
etc., using Turbo C 2.01 under Windows XP, and it works just fine.
I think it's probably the other way around.
I've just tested the program you posted, the one with:
int c;
and
while(1)
{
c = fgetc(fp);
etc., using Turbo C 2.01 under Windows XP, and it works just fine.
R
Richard Heathfield
Morris Dovey said:
The program he posted works just fine using Turbo C 2.01 under Windows XP.
I'm not sure what his problem is, but the problem isn't with the program,
the implementation, or the operating system.
Ah, but that's what make is for. When make says "'target' is up to date",
you know you've forgotten something!
The program he posted works just fine using Turbo C 2.01 under Windows XP.
I'm not sure what his problem is, but the problem isn't with the program,
the implementation, or the operating system.
My favorite trick is making changes in an edit window, then
compiling, linking, and running the program without having saved
my changed source file.
Ah, but that's what make is for. When make says "'target' is up to date",
you know you've forgotten something!
S
santosh
broli said:
Yes.
W
WANG Cong
On Sat, 15 Mar 2008 03:02:08 -0700，broli wrote：
This program works perfectly fine here. I am using gcc on an
i386 Linux.
What's your problem there and what's your environment?
This program works perfectly fine here. I am using gcc on an
i386 Linux.
What's your problem there and what's your environment?
B
Bartc
santosh said:
gcc -Wall (mingw version) doesn't give a warning about char c=fgetc().
lcc-win32 -A does give a warning.
Pelles C (or any other running under IDE) I wouldn't have a clue how to set
warning level.