Use of undefined constant error

[wyclef]

Hi, I am getting a use of undefined constant error on items like title, description, pubdate, etc. is the fix to this just to encapsulate everything in ' ' ?

} else if ($fileName == 'video') {
        for($i = 0; $i < count($items); $i++) {
            if ($items[$i][description] != '') {
                $feed .= '<item>';
                $feed .= '<title><![CDATA['.$items[$i][title].']]></title>';
                $feed .= '<description><![CDATA['.$items[$i][description].']]></description>';
                $feed .= '<pubDate>'.convertPubDate($items[$i][pubDate], 'l, M. dS, g:iA').'</pubDate>';
                $feed .= '<link><![CDATA['.$items[$i][link].']]></link>';
                if ($items[$i][mediacast.':'.thumbii] != '') {
                    $feed .= '<thumb>'.$items[$i][mediacast.':'.thumbii].'</thumb>';
                } else {
                    $feed .= '<thumb>https://mydomain.com/wp-content/themes/mytheme/assets/images/video.jpg</thumb>';
                }
                $feed .= '</item>';
            }
        }
    }

Does this work?

} else if ($fileName == 'video') {
        for($i = 0; $i < count($items); $i++) {
            if ($items[$i][description] != '') {
                $feed .= '<item>';
                $feed .= '<title><![CDATA['.$items[$i]['title'].']]></title>';
                $feed .= '<description><![CDATA['.$items[$i]['description'].']]></description>';
                $feed .= '<pubDate>'.convertPubDate($items[$i]['pubDate'], 'l, M. dS, g:iA').'</pubDate>';
                $feed .= '<link><![CDATA['.$items[$i]['link'].']]></link>';
                if ($items[$i][mediacast.':'.thumbii] != '') {
                    $feed .= '<thumb>'.$items[$i][mediacast.':'.thumbii].'</thumb>';
                } else {
                    $feed .= '<thumb>https://mydomain.com/wp-content/themes/mytheme/assets/images/video.jpg</thumb>';
                }
                $feed .= '</item>';
            }
        }
    }

I use Sublime Text 3, is there some syntax checker I could run my code through for stuff like this to make sure I get it all?

 

[John Rostron]

I use WeBuilder from Blumenthals. It has a PHP syntax checked as well as a PHP preview.
John

 

[MeMate]

First of all, hust as better coding habit use ['description'] instead of description. Both work, It's just a "way of should do" not "way have to".

Next is simple.

if ($items[$i][description] != '') {

i would go with something like this: (untested)

function lenNotNull($array){
    $okay=true;
    foreach($array as $key => $val){
          $v=trim($val);
          if(strlen($v)<1){return false;}
    }
 return $okay;
}

And then just

 if (lenNotNull($items[$i])) {

instead of

 if ($items[$i][description] != '') {