What is wrong in this code ?

[sunny]

hai
i am not able to overload a member function of base class in derived
calss.what is the wrong thning i am doing here in the following
program.


# include<iostream>
using namespace std;

class Quad
{
public:
void Area() ;
void Desc() ;
};

class Square : public Quad
{
public:
using Quad:Area;
void Area(int x)
{
cout<<"Area of square is = "<<x*x<<endl;
}
void Desc()
{
cout<<"This Derived class Square from Base Class Quad"<<endl;
}
};
class Rectangle : public Quad
{
public:
using Quad:Area;
void Area(int x, int y)
{
cout<<"Area of Rectangle is = "<<x*y<<endl;
}
void Desc()
{
cout<<"This Derived class Rectangle from Base Class Quad"<<endl;
}
};

class Creator
{
public:
Quad* Creator::Create(int id)
{
if(id==2)
return new Square;
else
return new Rectangle;
}
};
int main(int argc, char* argv[])
{
Creator mcreator;
if (argc<=2)
{
Quad *square=mcreator.Create(argc);
square->Area(3);
square->Desc();
}
else
{
Quad *rectangle=mcreator.Create(argc);
rectangle->Area(3,4);
rectangle->Desc();
}
return 0;

}

 

[Ivan Vecerina]

: i am not able to overload a member function of base class in derived
: calss.what is the wrong thning i am doing here in the following
: program.
In C++, you need to explicitly state that a function can
be overriden in a subclass.
(you wanted to say *override*, overload has a different meaning).

: # include<iostream>
: using namespace std;
:
: class Quad
: {
: public:
: void Area() ;
: void Desc() ;
You should write:
virtual void Area() =0;
virtual void Desc() =0;

Further adding =0 tells the compiler that the member function
is *abstract* (=> not implemented in this class) in addition
to being virtual.

: };
: class Square : public Quad
: {
...... [ok code] .....
: class Creator
: {
: public:
: Quad* Creator::Create(int id)
: {
: if(id==2)
: return new Square;
: else
: return new Rectangle;
: }
NB: make sure to learn to use std::auto_ptr
to avoid forgetting to delete the objects
that are created with new.

: };
: int main(int argc, char* argv[])
: {
: Creator mcreator;
: if (argc<=2)
: {
: Quad *square=mcreator.Create(argc);
: square->Area(3);
: square->Desc();
: }
: else
: {
: Quad *rectangle=mcreator.Create(argc);
: rectangle->Area(3,4);
: rectangle->Desc();
: }
: return 0;
:
: }

hth --Ivan

 

[Allen]

You cannot use base class pointer to call overloaded subclass member
function.

#include<iostream>
using namespace std;

class Quad
{
public:
void Area();
void Desc();
};

class Square : public Quad
{
public:
Square() {};

void Area(int x)
{
cout<<"Area of square is = "<<x*x<<endl;
}

void Desc()
{
cout<<"This Derived class Square from Base Class Quad"<<endl;
}
};

class Rectangle : public Quad
{
public:
Rectangle() {};

void Area(int x, int y)
{
cout<<"Area of Rectangle is = "<<x*y<<endl;
}

void Desc()
{
cout<<"This Derived class Rectangle from Base Class Quad"<<endl;
}

};

class Creator
{
public:
Quad* Creator::Create(int id)
{
if (id==2)
return new Square;
else
return new Rectangle;
}
};

int main(int argc, char* argv[])
{
Creator mcreator;
if (argc<=2)
{
Square *square = reinterpret_cast<Square*>(mcreator.Create(2));
square->Area(3);
square->Desc();
}
else
{
Rectangle *rectangle =
reinterpret_cast<Rectangle*>(mcreator.Create(1));
rectangle->Area(3,4);
rectangle->Desc();
}

return 0;
}

 

[Allen]

Or in overlapped version. It can do.


#include<iostream>
using namespace std;

class Quad
{
public:
virtual void Area(int x) {};
virtual void Area(int x, int y) {};
virtual void Desc() {};
};

class Square : public Quad
{
public:
Square() {};

void Area()
{
cout<<"Area of square is = 0"<<endl;
}

void Area(int x)
{
cout<<"Area of square is = "<<x*x<<endl;
}

void Desc()
{
cout<<"This Derived class Square from Base Class Quad"<<endl;
}
};

class Rectangle : public Quad
{
public:
Rectangle() {};

void Area()
{
cout<<"Area of Rectangle is = 0"<<endl;
}

void Area(int x)
{
cout<<"Area of Rectangle is = "<<x*x<<endl;
}

void Area(int x, int y)
{
cout<<"Area of Rectangle is = "<<x*y<<endl;
}

void Desc()
{
cout<<"This Derived class Rectangle from Base Class Quad"<<endl;
}

};

class Creator
{
public:
Quad* Creator::Create(int id)
{
if (id==2)
return new Square;
else
return new Rectangle;
}
};

int main(int argc, char* argv[])
{
Creator mcreator;
if (argc<=2)
{
Quad *square = mcreator.Create(2);
square->Area(3);
square->Desc();
}
else
{
Quad *rectangle = mcreator.Create(1);
rectangle->Area(3,4);
rectangle->Desc();
}

return 0;
}

 

[sototh]

Allen napisal(a):

Square *square = reinterpret_cast<Square*>(mcreator.Create(2));

It is VERY BAD, UNSAFE practice to use reinterpret_cast here! Proper
way is to use dynamic_cast.

My proposal is:

class Quad
{
public:
void Area(); // not needed, it should be dropped out
virtual void Desc() = 0; // every derived class will have to
// implement this function
};


/*-------- Square ----------*/

class Square : public Quad
{
public:
void Area(int x);
void Desc();
};

void Square::Area(int x)
{
cout << "Area of square is = " << x*x << endl;
}

void Square:esc()
{
cout << "This Derived class Square from Base Class Quad" << endl;
}


/*------ Rectangle ---------*/

class Rectangle : public Quad
{
public:
void Area(int x, int y);
void Desc();
};

void Rectangle::Area(int x, int y)
{
cout << "Area of Rectangle is = " << x*y << endl;
}

void Desc()
{
cout << "This Derived class Rectangle from Base Class Quad" << endl;
}


/*-------- Creator -----------*/

class Creator
{
public:
Quad* Create(const int id);
};

Quad* Creator::Create(const int id)
{
if (id == 2)
return new Square();
else
return new Rectangle();
}


/*--------- Let's use this stuff -------*/

int main(int argc, char* argv[])
{
Creator mcreator;

if (argc <= 2) {
// below we use dynamic_cast. It checks if Square is really
// a subclass of this Quad object and then does casting
Square* square = dynamic_cast<Square*>(mcreator.Create(argc));
square->Area(3);
square->Desc();

// do not forget to do some cleanups, to avoid memory leaks
delete square;

} else {
Rectangle* rectangle =
dynamic_cast<Rectangle*>(mcreator.Create(argc));
rectangle->Area(3,4);
rectangle->Desc();

delete rectangle;
}

return 0;
}


/*----- Another, more compact and safe version --------*/

int main(int argc, char* argv[])
{
Creator mcreator;

Quad* quad = mcreator.Create(argc);

if (argc <= 2) {
dynamic_cast<Square*>(quad)->Area(3);

} else {
dynamic_cast<Rectangle*>(quad)->Area(3,4);
}

quad->Desc(); // it uses Desc() version of Square or Rectangle,
// according to type of created object,
// beacause Quad.Desc() is virtual

delete quad;

return 0;
}

 

[I V]

hai
i am not able to overload a member function of base class in derived
calss.what is the wrong thning i am doing here in the following
program.

As another poster said, what you want to do here is _override_ (provide a
function with the same interface as another function), not
_overload_ (provide a function with the same name, but a different
interface).

class Quad
{
public:
void Area() ;
void Desc() ;

Here, you are declaring that Quad has functions Area and Desc, both taking
no arguments.

};

class Square : public Quad
{
public:
using Quad:Area;
void Area(int x)
{
cout<<"Area of square is = "<<x*x<<endl;
}

Here, you are saying Square has a function Area taking one argument. Note
that this function is _completely unrelated_ to the function "Area" in the
Quad class. Likewise, the function Area in the Rectangle class, taking two
arguments, is unrelated to the Area functions of either Quad or Square.

What you need to do is give Square and Rectangle functions called Area
that take no arguments; then, they will have the same interface as Quad
(you also need, as another poster pointed out, to find out how to use the
"virtual" keyword).

To get you started - this is a possible main function you could use.

int main()
{
Creator c;

Quad* quad = c.Create(2);
quad->Desc();
quad->Area();

delete quad;

quad = c.Create(4,5);
quad->Desc();
quad->Area();

delete quad;
}