Dr said:
In comp.lang.javascript message <
[email protected]
september.org>, Fri, 12 Jun 2009 19:22:56, Garrett Smith
You are premature. Your proposals posted in the group have not been
approved; discussion is continuing. There is at least one change that
has not been presented in the current thread on the topic, and it can be
improved.
Change month to JSmonth, and the code to
I understand "month", but what is JSmonth? JavaScript Month?
The convention genereally agreed on is that "upper camel case" is
intended for constructors.
It seems wrong include the letter abbreviation for the common
abbreviation of the language as a variable identifier for that language.
JSmonth = parts[2] - 1
date.setFullYear(parts[1], JSmonth, parts[3]);
if ( date.getMonth() != JSmonth ) {
And "with year in" would be better on the next line; your borders mean
that it does not fit on my page. With those borders, 64 characters is
enough.
Code wrapped at 64 characters? Usually 72 is narrow enough for most
editors (and the newsgroup).
Also, the routine rejects year 9999.
Thanks, fixed.
I had a mistake with manually converting '>' to &gt;=. Well, two,
actually.
Code which has not been tested and has not been reviewed here should not
be in the newsgroup FAQ.
I agree. I did mention that I would be uploading the changed version soon.
After typing that, you should have read it and corrected its "English".
I did. Just not before clicking "send". Posting typos and bungled
grammar to the list is embarrassing. Good think it did not go on the FAQ.
Additionally, "critically" may be taken to imply disapproval.
Possibly. I'm open to suggestions.
The idea is to make the FAQ more reader-friendly, more organized, and
less blah-blah. The tone of the writing is a little condescending in a
few parts.
Telling the reader that they are reading a document that was intended to
reduce noise says that the document they are reading is a preventative
measure that is to benefit the FAQ author/or group regulars. I would
rather have the reader feel that it is worthwhile and personally
beneficial to read the material for the merits of the material.
A reader of the group who gets a "RTFFAQ type of reply" and then
proceeds to duly read the FFaq, and then encounters that would seem a
bit insulted. It seems a little condescending, I think.
I know, typos and broken grammar have the opposite effect of making the
FAQ easy to read. They also diminish the quality. Luckily, I caught
those before they made it in.
The fact that when I post a change to the FAQ generates such a commotion
seems to be evidence that the FAQ is read.
Also, it's not reviewed on a daily basis. One part is presented daily;
some presentations get responses.
By "review" I did not mean that a response-review was posted to the
list, though I can completely see where you are coming from. Moreover,
no response does not imply agreement (as some rude posters might
wishfully think). It would be best to change the wording of that, to
avoid confusion.
| The c.l.js FAQ is a reliable resource that is read and criticized
| by experts. It provides URLs to further information about ECMAScript
| and browser scripting, and some tips to make your stay in
| comp.lang.javascript more enjoyable.
Note: I do not agree with all that you have said. I do appreciate the
technical responses you've provided. You have uncommon knowledge of
Dates and Number. Your knowledge in this area is valuable. Thanks.
Garrett