cell.onclick="..." not work?

Peter · Feb 12, 2006

Hi, this is the code, and new row and new cell generated ok, but why
the
onclick and onmouseover doen't work?
Thank you in advance!

<html>
<head>
<script language="javascript">
function inserttable()
{
alert("running");
var oRow = testtable.insertRow();
var cell = oRow.insertCell();
cell.innerHTML = "hello";
cell.onclick="javascript:alert('hello');";
cell.onmouseover = "javascript:alert('mouseOver');"
return;
}
</script>
</head>
<body>
<table>
<tr>
<td><input type="button" name="Test" value="Click"
onclick="javascript:inserttable();"></td>
</tr>
<tbody id="testtable">
</tbody>
</table>
</body>
</html>

Thomas 'PointedEars' Lahn · Feb 12, 2006

Peter said:
cell.onclick="javascript:alert('hello');";

Read about such `javascript:' nonsense in this newsgroup's FAQ.
Furthermore, the value of the (proprietary) `onclick' property
of DOM element objects has to be a Function object reference,
`null' or `undefined'. Since you want the UA do something on
event:

cell.onclick = function()
{
alert('hello');
};

BTW, this is definitely a FAQ here. Please do research on previous
articles before you post, it is both very annoying and tiresome to
answer the same questions all over again. It is called _news_group
for a reason.

BTW 2: Your HTML code is not Valid markup.

<URL:http://validator.w3.org/>

PointedEars

RobG · Feb 13, 2006

Peter said:
Hi, this is the code, and new row and new cell generated ok, but why
the
onclick and onmouseover doen't work?

Because there are errors in the script.

Thank you in advance!

<html>
<head>
<script language="javascript">

The language attribute is deprecated, type is required:

function inserttable()
{
alert("running");
var oRow = testtable.insertRow();
var cell = oRow.insertCell();
cell.innerHTML = "hello";
cell.onclick="javascript:alert('hello');";

'javascript:' is typically used as a pseudo-protocol in the value of a
href attribute of an A element, e.g.:

<a href="javascript:someFn();" ... >

However usually a real href should be supplied and an onclick handler
used for the script:

<a href="realPage" onclick="someFn();return false;" ... >

When setting the value of an onclick property using script, you can't
just plug in arbitrary code, use either an anonymous function:

cell.onclick = function(){alert('hello');}

or define the function elsewhere and pass a reference:

function sayHello()
{
alert('hello');
}

function inserttable()
{
...
cell.onclick = sayHello; // Note lack of '()'
...
}

cell.onmouseover = "javascript:alert('mouseOver');"

Same for onmouseover.

return;
}
</script>
</head>
<body>
<table>
<tr>
<td><input type="button" name="Test" value="Click"
onclick="javascript:inserttable();"></td>

Here 'javascript:' should be omitted, leaving just the function call:

<td ... onclick="inserttable();"></td>

And it is normal to give a button a more meaningful label than 'click',
but I guess this is just an example.

</tr>
<tbody id="testtable">

A tbody element without rows is invalid HTML ... but not too many user
agents will quibble over that.

Only one table shows up with the information	2	Mar 29, 2023
Uncaught ReferenceError: item is not defined at HTMLButtonElement.onclick in the: <button onclick="item.inserir()">Inserir dados</button>	1	Apr 21, 2023
Can someone tell me if this a real tracker? Or is it one designed to show you a different message at certain times, ie. acting like one?	0	Jan 10, 2021
Javascript DOM	1	Mar 29, 2023
Can someone pls help me with a little algorithm script	1	Nov 28, 2024
How to wrap <td> content .	16	Sep 27, 2023
Script to send email not working	1	Apr 10, 2023
Having trouble centering contents of td ?	3	May 2, 2023

cell.onclick="..." not work?

Peter

Thomas 'PointedEars' Lahn

RobG

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads