how do I make this case-insensitive

windandwaves · Apr 23, 2006

Hi Folk

I have the following function:

function eli() {
if (!document.getElementsByTagName) return;
var anchors = document.getElementsByTagName("A");
for (var i=0; i<anchors.length; i++) {
var anchor = anchors;
if (anchor.getAttribute("HREF") && anchor.getAttribute("rel") ==
"external") {
anchor.target = "_blank";
}
}
}

I run this function here : <body onload="eli();">. It adds the
target="_blank" attribute to all links that are written as follows:

<A HREF="http://www.somefruitcakesite.com" rel="external">my link</a>

How do I make it case insensitive. So that it also picks up:

<A href="http://www.somefruitcakesite.com" rel="EXTERNAL">my link</a>
<A href="http://www.somefruitcakesite.com" REL="external">my link</a>

etc...

Or is that too much work and should I adjust my html.

TIA

Joshie Surber · Apr 23, 2006

How do I make it case insensitive?

Change

if (anchor.getAttribute("HREF") && anchor.getAttribute("rel") == "external") {
To

if (anchor.getAttribute("HREF") && ( anchor.getAttribute("rel").toLowerCase == "external" || anchor.getAttribute("REL").toLowerCase == "external" ) ) {

This should do the trick. You may want to put in the same || for your
HREF too, since if you are serving this page as xml+xhtml (or use a
XHTML DOCTYPE in some browsers) all attributes are case sensitive.

<opinion about="standards" intent="friendly advice">On the other hand,
while this will make your code work, in reality you should probabally
standardize on using all lowercase -- if you are using XHTML lowercase
is required and if not, when you wind up eventually upgrading you won't
have as much maintenance to do. HTML Tidy (http://tidy.sf.net) can
automate this for you on your attribute names, but the values would be
up to you.</opinion>

BootNic · Apr 23, 2006

windandwaves said:
Hi Folk

I have the following function:

function eli() {
if (!document.getElementsByTagName) return;
var anchors = document.getElementsByTagName("A");
for (var i=0; i<anchors.length; i++) {
var anchor = anchors;
if (anchor.getAttribute("HREF") && anchor.getAttribute("rel") ==
"external") {
anchor.target = "_blank";
}
}
}

I run this function here : <body onload="eli();">. It adds the
target="_blank" attribute to all links that are written as follows:

<A HREF="http://www.somefruitcakesite.com" rel="external">my
link</a>

How do I make it case insensitive. So that it also picks up:

<A href="http://www.somefruitcakesite.com" rel="EXTERNAL">my
link</a> <A href="http://www.somefruitcakesite.com"
REL="external">my link</a>

etc...

Or is that too much work and should I adjust my html.

Adjustments would be a good ideal.

<script type="text/javascript">
function eli() {
var i,j,elix;
for (i=0, j=document.links.length; i<j; i++) {
elix=document.links;
if(elix.href && elix.rel.match(/external/i)){
elix.target="_blank";
}}}
</script>

--
BootNic Saturday, April 22, 2006 11:52 PM

"This is all very interesting, and I daresay you already see me
frothing at the mouth in a fit; but no, I am not; I am just winking
happy thoughts into a little tiddle cup."
*Nabokov, Lolita*

RobG · Apr 23, 2006

----------------------^^ --------------------------^^

getLowerCase is a method, use:

if (...toLowerCase() == "external" ...toLowerCase()...

windandwaves · Apr 23, 2006

Joshie said:
This should do the trick. You may want to put in the same || for your
HREF too, since if you are serving this page as xml+xhtml (or use a
XHTML DOCTYPE in some browsers) all attributes are case sensitive.

<opinion about="standards" intent="friendly advice">On the other hand,
while this will make your code work, in reality you should probabally
standardize on using all lowercase -- if you are using XHTML lowercase
is required and if not, when you wind up eventually upgrading you
won't have as much maintenance to do. HTML Tidy (http://tidy.sf.net)
can automate this for you on your attribute names, but the values
would be up to you.</opinion>

Totally agree, I will actually do this, but it is a huge site:
www.friars.co.nz and it takes time to go through all the code (PHP) and
adjust (well, about four hours I estimate).

Thanks for the help.

How do I make this craftinfsystem Work	1	Feb 9, 2023
Can someone tell me if this a real tracker? Or is it one designed to show you a different message at certain times, ie. acting like one?	0	Jan 10, 2021
I am trying to make an auto-play thing. How do I make it work?	5	Apr 5, 2022
getElementsByTagName + getAttribute("class")??	3	Oct 20, 2005
How can I add React 18 to existing HTML?	2	Mar 27, 2023
I am trying to make an audio player, how do I get the selected file to be playable?	5	Mar 29, 2022
Make 'Image X' spin 360deg on y-Axis until reset button clicked	1	Jan 22, 2023
Help with code	0	Jun 12, 2022

how do I make this case-insensitive

windandwaves

Joshie Surber

BootNic

RobG

windandwaves

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads