question about importing a package

[Matt]

I have a directory structure that looks like this:

sample.py
sub_one/
__init__.py # defines only the list __all__ = ['foo', 'bar']
foo.py # defines the function in_foo()
bar.py # defines the function in_bar()

In sample.py, I have this command at the top:

from sub_one import *

I can't refer to in_foo() and in_bar() without prefacing them with the module names. I.e. foo.in_foo() and bar.in_bar() work, but I want to import them in the __main__ namespace of sample.py and refer to them as just in_foo()and in_bar(). I know this is frowned upon, but for my purposes it is the best choice. I have about 30 modules in my package (foos and bars) and I don't want 30 lines at the top of each file that uses this package. What am I doing wrong?

Thanks,

Matt

 

[Chris Angelico]

I have about 30 modules in my package (foos and bars) and I don't want 30 lines at the top of each file that uses this package. What am I doing wrong?

Not necessarily wrong, but definitely something to query: WHY do you
have thirty modules in your package? How big are your source files -
could you simply merge them into a single module?

ChrisA

 

[alex23]

I have a directory structure that looks like this:

sample.py
sub_one/
      __init__.py     # defines only the list    __all__ = ['foo', 'bar']
      foo.py           # defines the function in_foo()
      bar.py           # defines the function in_bar()

In sample.py, I have this command at the top:

from sub_one import *

What am I doing wrong?

The statement `from sub_one import *` imports from sub_one/
__init__.py, which only imports the two modules into its namespace,
not their contents. What you need to do is bring into __init__.py
everything you want the star-import to pull into your code:

__init__.py:
from foo import *
from bar import *

foo.py:
__all__ = [ 'in_foo' ]
def in_foo():
...

bar.py:
__all__ = [ 'in_bar' ]
def in_bar():
...

If you structure is like this, you can restrict which items can be
imported within the defining file. If it doesn't make sense to do it
there, remove __all__ and just import directly in the __init__.

 

[Steven D'Aprano]

I have a directory structure that looks like this:

sample.py
sub_one/
__init__.py # defines only the list __all__ = ['foo', 'bar']
foo.py # defines the function in_foo()
bar.py # defines the function in_bar()

In sample.py, I have this command at the top:

from sub_one import *

I can't refer to in_foo() and in_bar() without prefacing them with the
module names. I.e. foo.in_foo() and bar.in_bar() work, but I want to
import them in the __main__ namespace of sample.py and refer to them as
just in_foo() and in_bar().

Module `sub_one` has two public names, "foo" and "bar", exactly as you
say. So when you import * from it, you only get two names. Now, you could
do any of these inside sample.py:

# 1
from sub_one.foo import in_foo
from sub_one.bar import in_bar


# 2
from sub_one import *
in_foo = foo.in_foo
in_bar = bar.in_foo


Or you could turn to sub_one.__init__ and do this:

# 3
__all__ = ['in_foo', 'in_bar']
from foo import in_foo
from bar import in_bar


or any combination of the above.

 

[Matt]

It works now. Steven and Alex, thanks for your help!

I ended up leaving sample.py and foo.py and bar.p the way they were, and in __init__.py putting:

from foo import *
from bar import *

So my mistake was not importing the foo and bar modules into sub_one/__init__.py.

I also see how the __all__ array helps me control what gets imported. I can leave it out of __init__.py, and everything gets imported. So my three lessons are:

1) "from X import *" will look for an __all__ list in module X, or in __init__.py if X is a package instead of a module, and import only what is in that list. Module names are different than function names in that list.
2) if __all__ is not defined, "from X import *' will import everything in X's namespace
3) __init__.py acts like just another module, so you have to import the package contents that you want into it before you import the package into your code

Thanks again for the help!

 

[Terry Reedy]

It works now. Steven and Alex, thanks for your help!

I ended up leaving sample.py and foo.py and bar.p the way they were, and in __init__.py putting:

from foo import *
from bar import *

So my mistake was not importing the foo and bar modules into sub_one/__init__.py.

I also see how the __all__ array helps me control what gets imported. I can leave it out of __init__.py, and everything gets imported. So my three lessons are:

1) "from X import *" will look for an __all__ list in module X, or in __init__.py if X is a package instead of a module, and import only what is in that list. Module names are different than function names in that list.
2) if __all__ is not defined, "from X import *' will import everything in X's namespace

.... that does not have a leading underscore. This is why there are
things like

import sys as _sys
from itertools import chain as _chain

in the stdlib when the module author does not define __all__.