Radio Button Question with Javascript

[amerar]

Hi All,

I am using this code to dynamically check is a radio button was checked
on the page. This worked great, if there is more then 1 button in the
group, but fails if there is only 1 button in the group......

Can anyone help debug? I'm stumped.....

function valButton(btn) {;
var cnt = -1;;
for (var i=btn.length-1; i > -1; i--) {;
if (btn.checked) {cnt = i; i = -1;};
};
if (cnt > -1) {return btn[cnt].value;};
else {return null;};
};


Thanks,

 

[Lee]

(e-mail address removed) said:

I am using this code to dynamically check is a radio button was checked
on the page. This worked great, if there is more then 1 button in the
group, but fails if there is only 1 button in the group......

Why would there be one button in a radio group?
Change the page that generates the form to eliminate the button or at least
change it to a checkbox if there's only one.

Can anyone help debug? I'm stumped.....

function valButton(btn) {;
var cnt = -1;;
for (var i=btn.length-1;

The problem is that if there is only one member, btn does not have a "length"
attribute.

 

[amerar]

Fixed it.....I put in a hidden button, just to force it to always be
2........

 

[RobG]

Fixed it.....I put in a hidden button, just to force it to always be
2........

And now you have a hidden trap for unwary maintainers of you page. Why
not test to see what btn is and deal with it appropriately?

function valButton(btn)
{
var len = btn.length;
if ('number' == typeof len) {
for (var i=0; i<len; ++i) {
if (btn.checked) return btn.value;
}
return null;
}
return (btn.checked)? btn.value : null;
}