<
[email protected]> ha scritto nel messaggioI've got one more error
that I can't seem to get worked out. I have a
segmentation fault and upon playing with my code, I think that it
crashes when I try to deallocate the "date" array.
Here's the most recent version of my code. Everything else seems to
work properly.
Absolutely not.
#include <stdio.h>
#include <stdlib.h>
#include <math.h>
Why?
int main(int argc, char *argv[])
{
/* Variable Declarations */
const int arraylength = 5;
I'd use size_t (if for some reason I had to avoid the preprocessor)...
const int errorcode = -1;
Why the hell do you need it?
float sum = 0;
int count = 0;
int condition = 1;
float* precipvals = (float*)NULL;
float* precip3hrs = (float*)NULL;
long* date = (long*)NULL;
These casts don't buy anything.
FILE *fpin;
FILE *fpout;
if (argv < 3) {
fprintf(stderr, "Usage:\t%s infile outfile\n", argv[0]);
return EXIT_FAILURE;}
/* or fpin = stdin, fpout = stdout, or ask the user what to do...*/
fpin = fopen(argv[1],"r");
if (fpin == NULL) { /* handle... */ }
fpout = fopen(argv[2],"w");
same as above...
/* Array Allocation */
precipvals = (float*)malloc(sizeof(int) * arraylength);
Why the hell sizeof(int)? And why do you need the cast?
precip3hrs = (float*)malloc(sizeof(int) * arraylength);
date = (long*)malloc(sizeof(int) * arraylength);
/* Calculation Section */
while(condition != EOF) {
while (condition < 2)
It is well possible that the file is ill-formed and you'll be able
to read date[count] but not precipvals[count]...
condition = fscanf(fpin,"%ld,%f", &date[count],
&precipvals[count]);
if(count == 0) {
precip3hrs[count] = precipvals[count];
}
if(count == 1) {
precip3hrs[count] = precipvals[count] + precip3hrs[count-1];
}
if(count > 1) {
precip3hrs[count] = precipvals[count] + precipvals[count-1] +
precipvals[count-2];
}
count++;
if (count >= arraylength) break;
}
/* Output section */
for(count = 0; count < arraylength; count++) {
if(count == 0) {
printf("One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
if(count == 1) {
printf("One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
Couldn't you bring these two out of the loop and make the loop
count from 2?
if(count > 1) {
printf("One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
}
/* Write to file */
for(count = 0; count < arraylength; count++) {
if(count == 0) {
fprintf(fpout, "One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
if(count == 1) {
fprintf(fpout,"One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
if(count > 1) {
fprintf(fpout,"One hour precipitation: %2.2f Three hour
precipitation %2.2f\n",precipvals[count],precip3hrs[count]);
}
}
fclose(fpin);
fclose(fpout);
if (fclose(fpout) != 0)
perror("Something went wrong");> printf("Testing\n");
/* Deallocation */
free(precipvals);
Why didn't you use free((void *)precipvals); this time?
precipvals = (float*)NULL;
free(precip3hrs);
precip3hrs = (float*)NULL;
free(date);
date = (long*)NULL;
return 0;
}
I'm just going by the way I was taught and how my book does it. I'm
not a professional programmer.
