syntax error OnClick

[trpost]

I hope this is a simple fix, but it has been driving me crazy, I have
the following code, that errors out with a syntax error:

<INPUT TYPE=button
OnClick=javascript:window.location='edit.php?action=remote&ID=1234&pw='+this.form.password.value+;
VALUE=remote update>

The specific piece that I narrowed the error down to is:
+this.form.password.value+;

If I exclude this, it works fine, but in my app I want to be able to
append the password field value from the form. Please help as I am by
no means a javascript expert, but just want to append the form field
value to the OnClick string.

Thanks

 

[web.dev]

<INPUT TYPE=button
OnClick=javascript:window.location='edit.php?action=remote&ID=1234&pw='+this.form.password.value+;
VALUE=remote update>

1. Do not use the javascript pseudo-protocol. It doesn't belong here
and is not needed.
2. It's generally a good idea to place quotes around attribute values.

The specific piece that I narrowed the error down to is:
+this.form.password.value+;

The last addition is not necessary.

Assuming you have an input element that's a password type with a name
'password', recommended solution is the following:

<input type = "password" name = "password">
<input type = "button"
onclick = "window.location='edit.php?etc=etc&pw=' +
this.form.elements['password'].value;"
value = "remote update">

 

[Richard Cornford]

1. Do not use the javascript pseudo-protocol. It
doesn't belong here and is not needed.

In the context of an intrinsic event attribute the - javascript: - is
the syntax for a label. A worthless label as no - break - or -
continue - statement refers to it, or would be meaningful in the code.

2. It's generally a good idea to place quotes around
attribute values.

It is a requirement of valid HTML that quotes be used around attribute
values that contain certain characters, and those characters are common
in javascript source code.

It is also likely that the HTML parser may see the character sequences -
&ID - and - &pw - as unrecognised entities so they probably should be -
&amp;ID - and - &amp;pw -.

The last addition is not necessary.

And a javascript syntax error.

Assuming you have an input element that's a password
type with a name 'password', recommended solution is
the following:

<input type = "password" name = "password">
<input type = "button"
onclick = "window.location='edit.php?etc=etc&pw=' +
this.form.elements['password'].value;"
value = "remote update">

Wouldn't:-

<form action="edit.php" method="GET">
<input type="hidden" name="ID" value="1234">
<input type="hidden" name="action" value="remote">
<input type="password" name="pw">
<input type="submit" value="remote update">
</form>

- be better yet as it is functional without any javascript dependency at
all. Though if any field is a password field sending the password value
as a text on a query string makes its interception trivial. A POST
request would be preferable.

Richard.