How do you feel about code reviews?

Discussion in 'C Programming' started by Robbie Brown, Jan 23, 2014.

  1. Robbie Brown

    Robbie Brown Guest

    Due to the excellent responses I've had so far I thought Id push my luck
    and ask how you (the collective you I suppose) feel about code reviews.

    Some people get upset if code is posted to a group, preferring instead
    to use pastebin or some such.

    The code in question is roughly 50 lines

    TIA
     
    Robbie Brown, Jan 23, 2014
    #1
    1. Advertisements

  2. Robbie Brown

    James Kuyper Guest

    Some people will complain about anything, but I doubt that many would
    complain about 50 lines of code.
     
    James Kuyper, Jan 23, 2014
    #2
    1. Advertisements

  3. Directly posted is preferred here, unless the code is really long.
    No one will complain about that.
     
    Ben Bacarisse, Jan 23, 2014
    #3
  4. Robbie Brown

    Kaz Kylheku Guest

    If we are talking about a Usenet group, they are idiots who should be ignored.
    Pastebin URL's eventually go bad, which destroys the archive of the discussion.

    If the code is thousand and thousands of lines, then pick a very small section
    of it for review.

    Perhaps some groups in the comp.sources.* hirearchy could be used for this;
    though some have been removed. There used to be comp.sources.review, for
    instance, but it is gone.
     
    Kaz Kylheku, Jan 23, 2014
    #4
  5. I sometimes feel like complaining about people who quote too
    much from previous posts, but even then 50 lines wouldn't do it.
    It is the many hundreds of lines, with a few new ones at the end,
    that I would complain about. Maybe even 1000's of lines!

    -- glen
     
    glen herrmannsfeldt, Jan 23, 2014
    #5
  6. I think there is nothing wrong with the occasional "please edit your
    replies" prodding -- especially if it can be combined with a helpful
    answer.
     
    Ben Bacarisse, Jan 23, 2014
    #6
    1. Advertisements

Ask a Question

Want to reply to this thread or ask your own question?

You'll need to choose a username for the site, which only take a couple of moments (here). After that, you can post your question and our members will help you out.