How do you feel about code reviews?

[Robbie Brown]

Due to the excellent responses I've had so far I thought Id push my luck
and ask how you (the collective you I suppose) feel about code reviews.

Some people get upset if code is posted to a group, preferring instead
to use pastebin or some such.

The code in question is roughly 50 lines

TIA

 

[James Kuyper]

Due to the excellent responses I've had so far I thought Id push my luck
and ask how you (the collective you I suppose) feel about code reviews.

Some people get upset if code is posted to a group, preferring instead
to use pastebin or some such.

The code in question is roughly 50 lines

Some people will complain about anything, but I doubt that many would
complain about 50 lines of code.

 

[Ben Bacarisse]

Due to the excellent responses I've had so far I thought Id push my
luck and ask how you (the collective you I suppose) feel about code
reviews.

Some people get upset if code is posted to a group, preferring instead
to use pastebin or some such.

Directly posted is preferred here, unless the code is really long.

The code in question is roughly 50 lines

No one will complain about that.

 

[Kaz Kylheku]

Some people get upset if code is posted to a group, preferring instead
to use pastebin or some such.

If we are talking about a Usenet group, they are idiots who should be ignored.
Pastebin URL's eventually go bad, which destroys the archive of the discussion.

If the code is thousand and thousands of lines, then pick a very small section
of it for review.

Perhaps some groups in the comp.sources.* hirearchy could be used for this;
though some have been removed. There used to be comp.sources.review, for
instance, but it is gone.

 

[glen herrmannsfeldt]

(snip)

Directly posted is preferred here, unless the code is really long.

No one will complain about that.

I sometimes feel like complaining about people who quote too
much from previous posts, but even then 50 lines wouldn't do it.
It is the many hundreds of lines, with a few new ones at the end,
that I would complain about. Maybe even 1000's of lines!

-- glen

 

[Ben Bacarisse]

I sometimes feel like complaining about people who quote too
much from previous posts, but even then 50 lines wouldn't do it.
It is the many hundreds of lines, with a few new ones at the end,
that I would complain about. Maybe even 1000's of lines!

I think there is nothing wrong with the occasional "please edit your
replies" prodding -- especially if it can be combined with a helpful
answer.