Javascrip code wont run properly.

amal · Oct 2, 2022

i always get error:
Uncaught ReferenceError: colourChosen is not defined
html:27:15
Untitled-6 (Isnt working).html:22 Uncaught ReferenceError: animalRadio is not defined
at HTMLButtonElement.onclick
createAnimal @ Untitled-6 (Isnt working).html:22
onclick @ Untitled-6 (Isnt working).html:16
the code is:
<html>
<body>
<select id="colour">
<option>red</option>
<option>yellow</option>
<option>purple</option>
<option>orange</option>
<option>green</option>
</select>
<form id="animals">
<input type="radio" name="animals" value="elephant">Elephant <br>
<input type="radio" name="animals" value="tortoise">Tortoise <br>
<input type="radio" name="animals" value="dolphin">Dolphin <br>
<input type="radio" name="animals" value="kangroo">Kangroo <br>
</form>
<button onclick="createAnimal ()">Create the animal</button>
<script>
function createAnimal () {
var dropDownName = document.getElementById("colour");
var colourChosen = dropDownName.options[dropDownName.selectedIndex].text;
for(i=0; i<4; i++){
if(animalRadio.checked) {
var animalChosen = animalRadio.value;
}
}
}
alert(colourChosen + " " + animalChosen);
</script>
</body>
</html>

MeMate · Oct 2, 2022

You need to globalize your vars. Right now they are available only within your function createAnimal

Try this:

Code:

var dropDownName,colourChosen,animalChosen=false;
function createAnimal () {
dropDownName = document.getElementById("colour");
colourChosen = dropDownName.options[dropDownName.selectedIndex].text;
for(i=0; i<4; i++){
if(animalRadio.checked) {
 animalChosen = animalRadio.value;
 }
 }
 }

!!NOTICE!!
animalRadio still not defined. Where is it in your code?

BigDady · Oct 3, 2022

MeMate is correct that the values you use in the alert are not defined outside of the function and that you should make them global. But you could also place the alert inside the function and things work out fine for that This will work

Code:

<script>
function createAnimal () {
    var dropDownName = document.getElementById("colour");
    var colourChosen = dropDownName.options[dropDownName.selectedIndex].text;

    for(i=0; i<4; i++){
        if(animals[i].checked) {
            var animalChosen = animals[i].value;
        }
    }
alert(colourChosen + " " + animalChosen);
}
</script>

I dont get this. Please help me!!	2	Jan 24, 2023
Very Basic CC Validation Javascript	0	Oct 29, 2019
Help with code	0	Jun 12, 2022
Uncaught ReferenceError: item is not defined at HTMLButtonElement.onclick in the: <button onclick="item.inserir()">Inserir dados</button>	1	Apr 22, 2023
Need Help, Both submit button works same, i need both submit button works differently, the one button override other button	3	Nov 9, 2022
Issue with textbox script?	0	Sep 5, 2022
Help me sort out this script	1	Oct 17, 2023
Check forms With JavaScript	1	Mar 28, 2023

Javascrip code wont run properly.

amal

MeMate

BigDady

Ask a Question

Similar Threads

Members online

Forum statistics

Latest Threads