How to literate a const char*

[silverburgh.meryl]

Hi,

how can I literator a const char*?

I have this code, but it results in an infinite loop. It never exits
the while (p1 != '\0') loop

void teststr( const char *str1) {
char* p1 = (char*)str1;


while (p1 != '\0') {
//....
p1 ++;
}

}

and i call teststr like this:

teststr("http://www.cnn.com");

Can you please tell me why i never exit the while loop?

Thank you.

 

[Ben Pfaff]

I have this code, but it results in an infinite loop. It never exits
the while (p1 != '\0') loop

void teststr( const char *str1) {
char* p1 = (char*)str1;

This is questionable. If you don't need to modify str1, then
declare p1 as const and drop the cast. If you do need to modify
str1, then don't declare str1 as const and drop the cast.

while (p1 != '\0') {

Should be
while (*p1 != '\0')
Note the *.

 

[Christopher Benson-Manica]

This is questionable. If you don't need to modify str1, then
declare p1 as const and drop the cast. If you do need to modify
str1, then don't declare str1 as const and drop the cast.

Note that OP passed a string literal to this function, so it seems
that the former is the right advice.