Splint errors

[Andrea Crotti]

I tried for curiosity to run splint on my code (and other code) and I
found this for example:

--8<---------------cut here---------------start------------->8---
SerialForwarder.h:41: Name _SERIALFORWARDER_H_ is in the implementation name
space (any identifier beginning with underscore)
External name is reserved for system use by ISO C99 standard. (Use either
-isoreserved or -namechecks to inhibit warning)
--8<---------------cut here---------------end--------------->8---

So is that really wrong to put guards written like this in the header?
How else am I supposed to call the guards otherwise?

Thanks..

 

[Joachim Schmitz]

I tried for curiosity to run splint on my code (and other code) and I
found this for example:

--8<---------------cut here---------------start------------->8---
SerialForwarder.h:41: Name _SERIALFORWARDER_H_ is in the
implementation name space (any identifier
beginning with underscore) External name is reserved for system use
by ISO C99 standard. (Use either
-isoreserved or -namechecks to inhibit warning)
--8<---------------cut here---------------end--------------->8---

So is that really wrong to put guards written like this in the header?
How else am I supposed to call the guards otherwise?

Without the leading _

Thanks..

Bye, Jojo

 

[Eric Sosman]

Without the leading _

Many people suggest guarding "foo.h" and "bar.h" with FOO_H
and BAR_H, respectively. Unfortunately, this breaks down for
header files like "event.h" because many macro names starting
with E are reserved when <errno.h> is in play ...

I'd recommend using H_FOO and H_BAR as safer, albeit uglier,
alternatives.