advice about `correct' use of decorator

[Gerardo Herzig]

Hi all. I guess i have a conceptual question:
Im planing using a quite simple decorator to be used as a conditional
for the execution of the function. I mean something like that:

@is_logued_in
def change_pass():
bla
bla

And so on for all the other functions who needs that the user is still
loged in.

where obviosly the is_logued_in() function will determine if the dude is
still loged in, and THEN execute change_pass(). If the dude is not loged
in, change_pass() is NOT executed at all. Instead, it will be redirected
to the `login' screen.

Something in my mind tells me that this is not the pythonic way...But i
like the idea, so please tell me that im in the right way

Cheers.
Gerardo

 

[Steven Bethard]

Hi all. I guess i have a conceptual question:
Im planing using a quite simple decorator to be used as a conditional
for the execution of the function. I mean something like that:

@is_logued_in
def change_pass():
bla
bla

And so on for all the other functions who needs that the user is still
loged in.

where obviosly the is_logued_in() function will determine if the dude is
still loged in, and THEN execute change_pass(). If the dude is not loged
in, change_pass() is NOT executed at all. Instead, it will be redirected
to the `login' screen.

Something in my mind tells me that this is not the pythonic way...But i
like the idea, so please tell me that im in the right way

Django does it almost exactly this way:

http://www.djangoproject.com/documentation/authentication/#the-login-required-decorator

STeVe

 

[Gerardo Herzig]

Gerardo Herzig wrote:



Django does it almost exactly this way:

http://www.djangoproject.com/documentation/authentication/#the-login-required-decorator

STeVe

Great! So from now on, my idea is labeled as `djangothic'
Thanks a lot!

Gerardo

 

[Bruno Desthuilliers]

Gerardo Herzig a écrit :

(snip)
>
Great! So from now on, my idea is labeled as `djangothic'
Thanks a lot!

Which doesn't necessarily imply it's pythonic !-)

 

[Lawrence D'Oliveiro]

@is_logued_in
def change_pass():
bla
bla

And so on for all the other functions who needs that the user is still
loged in.

My suspicion is that most of the methods in your session object (with the
obvious exception of the login method) will require the user to be logged
in, right?

So the trouble with an extra decorator like this, is that you have to
remember to put it on nearly _all_ your methods.

Wouldn't it be simpler and safer to default the other way? Have some way of
saying "doesn't require user to be logged in", and require a valid
logged-in session on all methods where this is not specified?

 

[Gregor Horvath]

@is_logued_in
def change_pass():
bla
bla

And so on for all the other functions who needs that the user is still
loged in.

where obviosly the is_logued_in() function will determine if the dude is
still loged in, and THEN execute change_pass(). If the dude is not loged
in, change_pass() is NOT executed at all. Instead, it will be redirected
to the `login' screen.

Something in my mind tells me that this is not the pythonic way...But i
like the idea, so please tell me that im in the right way

That's how turbogears does it.
See:

http://docs.turbogears.org/1.0/UsingIdentity?highlight=(identity)


Greg